Skip to content

Port rustc_reservation_impl to the new attribute parser #152180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Feb 9, 2026
Merged

Port rustc_reservation_impl to the new attribute parser #152180

rust-bors merged 1 commit into from
Feb 9, 2026

Conversation

@jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Feb 5, 2026

@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2026
@jdonszelmann jdonszelmann mentioned this pull request Feb 5, 2026
Open
9 tasks
JonathanBrouwer
JonathanBrouwer reviewed Feb 5, 2026
View reviewed changes
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 5, 2026

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 5, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@jdonszelmann jdonszelmann force-pushed the port-rustc-reservation-impl branch from e4bfc54 to 86daea3 Compare February 7, 2026 13:33
@rustbot

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 7, 2026

should be better now @JonathanBrouwer @rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 7, 2026
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 7, 2026

rangediff should be pretty clear

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 7, 2026

@bors r+ rollup
Yep awesome, ty :)

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 7, 2026

📌 Commit 86daea3 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 7, 2026

@bors r-
Actually isn't that one rust-analyzer test gonna fail now?
r=me if ci green

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2026
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 7, 2026

@bors r+
I guess not

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 7, 2026

📌 Commit 86daea3 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152180 - jdonszelmann:port-rustc-reservatio…
9853bec 
…n-impl, r=JonathanBrouwer

Port `rustc_reservation_impl` to the new attribute parser

r? @JonathanBrouwer
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152180 - jdonszelmann:port-rustc-reservatio…
bcba606 
…n-impl, r=JonathanBrouwer

Port `rustc_reservation_impl` to the new attribute parser

r? @JonathanBrouwer
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 7, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152180 - jdonszelmann:port-rustc-reservatio…
dbad4a0 
…n-impl, r=JonathanBrouwer

Port `rustc_reservation_impl` to the new attribute parser

r? @JonathanBrouwer
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 7, 2026
Closed
@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@jdonszelmann jdonszelmann force-pushed the port-rustc-reservation-impl branch from 86daea3 to f248ac0 Compare February 8, 2026 21:31
@rustbot

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 8, 2026

@bors r=jonathanbrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 8, 2026

📌 Commit f248ac0 has been approved by jonathanbrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2026
@Zalathar Zalathar mentioned this pull request Feb 9, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 9, 2026
@bors
Auto merge of #152373 - Zalathar:rollup-wDsfoHs, r=Zalathar
4cd4c18 
Rollup of 4 pull requests

Successful merges:

 - #150823 (Implement MVP for opaque generic const arguments)
 - #152071 (Implement stdio FD constants)
 - #152171 (Port `rustc_strict_coherence` to the new attribute parser)
 - #152291 (Port `rustc_insignificant_dtor`)

Failed merges:

 - #152180 (Port `rustc_reservation_impl` to the new attribute parser)
@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 9, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 9, 2026
@jdonszelmann jdonszelmann force-pushed the port-rustc-reservation-impl branch from f248ac0 to 6babe68 Compare February 9, 2026 09:55
@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Feb 9, 2026

@bors r=jonathanbrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 9, 2026

📌 Commit 6babe68 has been approved by jonathanbrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 9, 2026
@jhpratt jhpratt mentioned this pull request Feb 9, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 9, 2026
@bors
Auto merge of #152382 - jhpratt:rollup-DIUVWuF, r=jhpratt
71dc761 
Rollup of 3 pull requests

Successful merges:

 - #152357 (std: Don't panic when removing a nonexistent UEFI var)
 - #152180 (Port `rustc_reservation_impl` to the new attribute parser)
 - #152276 (Add message format checking)
@rust-bors rust-bors bot merged commit 98a3fa2 into rust-lang:main Feb 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 9, 2026
rust-timer added a commit that referenced this pull request Feb 9, 2026
@rust-timer
Unrolled build for #152180
ac5fb86 
Rollup merge of #152180 - jdonszelmann:port-rustc-reservation-impl, r=jonathanbrouwer

Port `rustc_reservation_impl` to the new attribute parser

r? @JonathanBrouwer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer left review comments

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jdonszelmann @rustbot @JonathanBrouwer